Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/unskip playwright tests #3279

Open
wants to merge 11 commits into
base: staging
Choose a base branch
from
Open

Fix/unskip playwright tests #3279

wants to merge 11 commits into from

Conversation

clari182
Copy link
Collaborator

@clari182 clari182 commented Dec 12, 2024 •
edited
Loading

  • Part of Fix skipped Playwright tests #2945
    Fixes those tests:
  • Should flag an incident
  • Should display Edit button only for Admin users
  • Should redirect to the account page when logged in
  • Should redirect to the signup page when logged out
  • Should redirect to the account page if the signup storage key is set
  • Should show fallback preview image on initial load
  • Should have read-only access for non-logged-in users

@codecov Codecov
Copy link

codecov bot commented Dec 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.35%. Comparing base (05b7f1c) to head (f6e3f8b).

Additional details and impacted files 
@@           Coverage Diff            @@
##           staging    #3279   +/-   ##
========================================
  Coverage    97.35%   97.35%           
========================================
  Files           59       59           
  Lines        13163    13163           
  Branches       300      300           
========================================
  Hits         12815    12815           
+ Misses         348      334   -14     
- Partials         0       14   +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clari182 clari182 mentioned this pull request Dec 12, 2024
Open
18 tasks
@clari182 clari182 marked this pull request as ready for review December 13, 2024 15:36
@clari182 clari182 requested a review from cesarvarela December 13, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cesarvarela cesarvarela Awaiting requested review from cesarvarela

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@clari182